Drop ConstrainResult mode bit #9641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a TypeComparer variable instead. This saves ~60K fresh contexts on typer/*.scala, which is roughtly 10%. It's also cleaner since it avoids a global mode bit.
liufengyun
approved these changes
Aug 26, 2020
| def necessarilyCompatible(tp: Type, pt: Type)(using Context): Boolean = | ||
| val tpw = tp.widenExpr | ||
| val ptw = pt.widenExpr | ||
| necessarySubType(tpw, ptw) || tpw.isValueSubType(ptw) || viewExists(tp, pt) |
There was a problem hiding this comment.
Does it matter?
Suggested change
| necessarySubType(tpw, ptw) || tpw.isValueSubType(ptw) || viewExists(tp, pt) | |
| necessarySubType(tpw, ptw) || tpw.isValueSubType(ptw) || viewExists(tpw, ptw) |
There was a problem hiding this comment.
I think it would matter if there is an implicit conversion between singleton types. In this case it should be viewExists(tp, pt)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a TypeComparer variable instead. This saves ~60K fresh contexts
on typer/*.scala, which is roughtly 10%. It's also cleaner since it
avoids a global mode bit.